fix(test): for "CI / Windows Unit Tests", skip TestSessionReconnect#15895
Open
nakatani-yo wants to merge 1 commit intoargoproj:mainfrom
Open
fix(test): for "CI / Windows Unit Tests", skip TestSessionReconnect#15895nakatani-yo wants to merge 1 commit intoargoproj:mainfrom
nakatani-yo wants to merge 1 commit intoargoproj:mainfrom
Conversation
…nnect. Signed-off-by: nakatani-yo <yoshihito.nakatani@craftsman-software.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
github.com/argoproj/argo-workflows/v4/util/sqldbin "CI / Windows Unit Tests" failed.This error "could not find plugin bridge in v1 plugin registry" indicates that the Docker daemon could not create a bridge network for Linux containers, meaning the Linux container execution infrastructure is not available in that environment. This can occur on Windows if Docker is running in Windows Containers mode, or if the bridge network driver is corrupted or disabled.
Confirmed
runs-on: windows-2022in.github/workflows/ci-build.yaml.TestSessionReconnectuses the Linux-based PostgreSQL test container (postgres:17.4-alpine). On Windows CI, that assumption does not hold, which causes the test to fail for an environment-specific reason rather than due to product behavior.For details on how to specify the test container, please refer to the following:
https://github.com/argoproj/argo-workflows/blob/main/util/sqldb/session_test.go#L30
Please refer to the following link for details regarding the supported platforms for postgres:17.4-alpine:
https://hub.docker.com/layers/library/postgres/17.4-alpine/
Modifications
TestSessionReconnectwhenruntime.GOOS == "windows".runtimeimport required for the platform check.Verification
util/sqldb/session_test.go.TestSessionReconnectnow exits early on Windows before attempting to start the Linux container image.Documentation